Problems in event_scripts

[schmoozerd]

Hi guys,

as I worked on some generic porting from event_scripts of ytdb to udb, i noticed some things that stroke me as pretty weird, hence i note them here, so that you can check yourselves, and maybe fix some erros in the database:

event-id 13052 - summons a bunch of mobs assigned to ManaTombs.
Event started by quest related spell (see comments)

SELECT * FROM event_scripts WHERE id=13052;
(13052, 3, 10, 18430, 180000, 0, 0, 0, 0, 0, 0, 0, 2534.55, 4007.9, 133.209, 4.06749, ''), -- 'started by spell', 35282, 'of item', 29447, 'of quest', 10309, 'It's a Fel Reaver, But with Heart'
(13052, 15, 10, 18431, 180000, 0, 0, 0, 0, 0, 0, 0, 2531.86, 4013.56, 133.815, 4.35965, ''), -- 'started by spell', 35282, 'of item', 29447, 'of quest', 10309, 'It's a Fel Reaver, But with Heart'
(13052, 30, 10, 18394, 180000, 0, 0, 0, 0, 0, 0, 0, 2533.75, 4007.99, 133.208, 3.41796, ''), -- 'started by spell', 35282, 'of item', 29447, 'of quest', 10309, 'It's a Fel Reaver, But with Heart'
(13052, 45, 10, 18430, 180000, 0, 0, 0, 0, 0, 0, 0, 2528.13, 3999.24, 132.698, 0.89761, ''), -- 'started by spell', 35282, 'of item', 29447, 'of quest', 10309, 'It's a Fel Reaver, But with Heart'
(13052, 60, 10, 18431, 180000, 0, 0, 0, 0, 0, 0, 0, 2532.62, 4002.53, 132.828, 1.9312, ''), -- 'started by spell', 35282, 'of item', 29447, 'of quest', 10309, 'It's a Fel Reaver, But with Heart'
(13052, 75, 10, 18394, 180000, 0, 0, 0, 0, 0, 0, 0, 2529.32, 4001.44, 132.815, 1.40734, ''), -- 'started by spell', 35282, 'of item', 29447, 'of quest', 10309, 'It's a Fel Reaver, But with Heart'
(13052, 90, 10, 18430, 180000, 0, 0, 0, 0, 0, 0, 0, 2526.62, 4008.99, 133.473, 5.46628, ''), -- 'started by spell', 35282, 'of item', 29447, 'of quest', 10309, 'It's a Fel Reaver, But with Heart'
(13052, 105, 10, 18431, 180000, 0, 0, 0, 0, 0, 0, 0, 2522.55, 4005.96, 133.451, 5.5943, ''), -- 'started by spell', 35282, 'of item', 29447, 'of quest', 10309, 'It's a Fel Reaver, But with Heart'
(13052, 120, 10, 18394, 180000, 0, 0, 0, 0, 0, 0, 0, 2525.31, 4007.75, 133.42, 5.94066, ''), -- 'started by spell', 35282, 'of item', 29447, 'of quest', 10309, 'It's a Fel Reaver, But with Heart'


Quest-related spell 16989 already has quest-complete 5096 effect

SELECT * FROM event_scripts WHERE id=5121;
(5121, 1, 7, 5096, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, ''), -- 'started by spell', 16989, 'of item', 12807, 'of quest', 5096, 'Scarlet Diversions'


Quest implemented in sd2

SELECT * FROM event_scripts WHERE id=10951;
(10951, 0, 10, 17652, 60000, 0, 0, 0, 0, 0, 0, 0, -11173.3, -1923.89, 91.4731, 0.0471124, ''), -- 'started by spell', 31114, 'of item', 23934, 'of quest', 9645, 'The Master's Terrace'


-- Pretty sure wrong: should just despawn the target of the spell (the old god likely).
-- the real difficulty here is that the required spell-focus must be summoned when all summoners are killed, this will require some SD2 scripting

SELECT * FROM event_scripts WHERE id=14293;
(14293, 5, 10, 22137, 600000, 0, 0, 0, 0, 0, 0, 0, -4192.25, 2005.34, 53.563, 0.49, ''), -- 'started by spell', 38482, 'of item', 31386, 'of quest', 10808, 'Thwart the Dark Conclave'
(14293, 5, 8, 22137, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, ''), -- 'started by spell', 38482, 'of item', 31386, 'of quest', 10808, 'Thwart the Dark Conclave'




SELECT * FROM event_scripts WHERE id=;

[NeatElves]

2. Тут да, скорее эвент на падение палатки (го 176210)
DELETE FROM `event_scripts` WHERE `id` = 5121;
3. Да, недавно перенесли в скрипты
DELETE FROM `db_script_string` WHERE `entry` = 2000000294;
DELETE FROM `db_script_string` WHERE `entry` = 2000000295;
DELETE FROM `db_script_string` WHERE `entry` = 2000000296;
DELETE FROM `db_script_string` WHERE `entry` = 2000000297;
DELETE FROM `db_script_string` WHERE `entry` = 2000000298;
DELETE FROM `db_script_string` WHERE `entry` = 2000000299;
DELETE FROM `db_script_string` WHERE `entry` = 2000000300;
DELETE FROM `db_script_string` WHERE `entry` = 2000000301;
DELETE FROM `event_scripts` WHERE `id` = 10951;

[YuruY]

2-3 Забирать?

[NeatElves]

Да, остальное еще не проверял...

[schmoozerd]

These two produce a startup error:
SELECT * FROM ytdb.event_scripts WHERE id IN (2244, 19588);

Error: The two event-ids are not found from current ways of triggering.
(possible core bug, needs more research)

[NeatElves]

These two produce a startup error:
SELECT * FROM ytdb.event_scripts WHERE id IN (2244, 19588);

Error: The two event-ids are not found from current ways of triggering.
(possible core bug, needs more research)

No startup error.)
2244 - there are plenty of similar quests(Felwood)

Кстати, по таким (http://ru.wowhead.com/item=11516#objective-of) квестам в лесу, надо вроде го деспавнить, а так как нет такой команды, то пришлось просто деактивировать.)))

[YuruY]

Ну это уже Шму проблема.