[11138] Make sure GameEvent/Pool systems work with static instance object guids

[newsbot]

автор: VladimirMangos


<pre>m src/game/Creature.cpp
m src/game/Creature.h
m src/game/GameEventMgr.cpp
m src/game/GameObject.cpp
m src/game/GameObject.h
m src/game/PoolManager.cpp
m src/game/SpellAuras.cpp
m src/shared/revision_nr.h
</pre>
<pre style='white-space:pre-wrap;width:81ex'>[11138] Make sure GameEvent/Pool systems work with static instance object guids

* Pool System for correct full power work in instance need implement
MapPersistentState local pool system state for instanceable maps.
Unit this not implemented pool system must avoid creating/despawn/touch
instance map objects. Currently this work because instance map object use
dynamic generated guids and "invisible" for Pool System, with explcitly forbiden
for it spawn directly new objects. Code changes add explicit checks for preserve
this way work for time when instance object will use static guids. When local pool
state storing in persistent state this protection checks will possible drop.
Non-instanced working cases converted in local map object search calls.

* GameEvent Systems currently have code that work correctly only with objects at
non-instanced maps by same reasons as Pool System. But in different Pool System
case game event activate/deactivate expected applied to _all_ object copies in all
existed instanceable map copies. Code modified for work in expected way.
Direct spawn disabled for instanceable maps until swith to static guids.
Despawn code will make affect only for non-instanceavble maps unit swithc to static guids as-is.
This is preserve current code working result.

* Convert last case usage global creature search in aura code to map local case.
Player case also possible not need now after including caster damage/heal mods
part to aura base damage/heal. In any cases player case preserved in old way work.

NOTE: this last places dependent from global creature/gameobject guid search so look like this
make possible start direct work to switch instances use static guids instead dynamic generated</pre>




Дальше...