Combat Rolls Overhaul: Abilities, Avoidance

[newsbot]

Автор: Warlockbugs


<pre style='white-space:pre-wrap;width:81ex'>Combat Rolls Overhaul: Abilities, Avoidance

Reuse existing code for ability calculation.
+Codestyle.
+Some caching in a few aura handlers.

Fixes and changes:
* Fix certain player chances behavior when dealing with negative values:
- Finally move away from using client-only fields for Melee Crit/Dodge/Parry/Block calculations
- Also optimize these chances for NPCs thanks to new variables.
- As a result of these changes, "Chill of the Throne" and similar effects now work correctly.
* Fix AoE avoidance for physical abilities:
- TBC: Felguard is now able to avoid Whirlwind and similar physical AoE effects.
* Player avoidance stats update:
- Moved base dodge out of GetDodgeFromAgility to avoid potential confusion, transform into calculating method with agility amount as an arg.
- Player field handlers for Dodge, Parry, Block are now unified across all cores.
- All local const array tables are moved out of their respective methods and placed next to them as static to avoid repeated initialization.
- WotLK: Percentages displayed in the UI player fields for Dodge, Parry and Block are no longer diminished (Blizzlike).
- WotLK: Avoidance diminishing returns are rewritten.
- WotLK: Miss chance diminishing from bonus defense is now implemented.
- WotLK: Diminishing from bonus defense rating is now dynamic.
- Vanilla: Removed additional hardcoded 1% dodge from NE (racial aura already takes care of that).
* Fix Dual Wield hit chance mistake from previous overhaul commit</pre>


Подробнее...