Global unit ownership redesign

[newsbot]

Автор: Warlockbugs


<pre style='white-space:pre-wrap;width:81ex'>Global unit ownership redesign

Functionality changes:
* Initial Pet, Guardian and Companion fields and flags are cleaned up according to gathered retail data.
* Unifies logical concept of unit ownership and it***39;s fields; allows overrides within WorldObject hierarchy.
* Adjusted ownership API for Pets, Totems, Guardians and Companions.
* Added recursive owner API specifically for current implementations of IsFriendlyTo and IsHostileTo to resolve some issues with summons like elementals.

Refactoring details:
* Introduced new term "Master", which resolves either to charmed or owner in one action, therefore:
- GetCharmerOrOwnerGuid() becomes GetMasterGuid()
- GetCharmerOrOwner() becomes GetMaster()
* Introduced a new term "Beneficiary" for cases when an instant action to get unit***39;s charmer, owner or itself was required, therefore:
- GetCharmerOrOwnerOrSelf() becomes GetBeneficiary()
- GetCharmerOrOwnerPlayerOrPlayerItself() becomes GetBeneficiaryPlayer()
* Usage cases of following unit methods were carefuly examined and replaced with fitting flag checks instead; methods were removed as excessive as a result:
- isCharmedOwnedByPlayerOrPlayer()
- IsCharmerOrOwnerPlayerOrPlayerItself()
- GetCharmerOrOwnerOrOwnGuid()

Quality of Life changes:
* Client is now able to correctly detect and display totems as a result of all changes done.</pre>


Подробнее...